mgmt, upgrade features RP#23211
Merged
weidongxu-microsoft merged 6 commits intoAzure:mainfrom Jul 29, 2021
Merged
Conversation
weidongxu-microsoft
requested review from
ChenTanyi,
haolingdong-msft,
qwordy and
yungezz
as code owners
ChenTanyi
approved these changes
Jul 28, 2021
Comment on lines
+20
to
+24
| features.stream() | ||
| .filter(f -> "NotRegistered".equals(f.state())) | ||
| .findFirst() | ||
| .ifPresent(feature -> resourceClient.features() | ||
| .register(feature.resourceProviderName(), feature.featureName())); |
Contributor
There was a problem hiding this comment.
I think find a Registered one is better (i think it could be registered). Otherwise when all providers are registered, the test can not test anything.
Member
Author
There was a problem hiding this comment.
For now most feature is NotRegistered (and we got lots of them for this test to run, we can change that after we exhausted them).
BTW, if I find Registered, I cannot call unregister on it as someone may depends on that feature.
Member
Author
|
/check-enforcer override |
Member
Author
|
all CI pass, just check-enforcer not done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests pass under resources
basically, only this is manual change fae32ca